Add renderer field to frameworks, and use to drive v6 store entrypoints
#19595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer try and do docs-page manager side.
Also ensure that the ClientAPI calculates the index correctly
…om/sb-732-docs2-support-docs-only-stories-in-v6
|
@shilman I'm seeing this error in the build process (for both v6+v7 SB's) (not sure why we didn't see it before):
I think it's because the magic "preview.js" handling isn't applying to these presets. |
…om/sb-732-docs2-support-docs-only-stories-in-v6
…om/sb-732-docs2-support-docs-only-stories-in-v6
shilman
approved these changes
Oct 25, 2022
| const frameworkInitEntry = path.resolve( | ||
| path.join(workingDir, 'storybook-init-framework-entry.js') | ||
| ); | ||
| virtualModuleMapping[frameworkInitEntry] = `import '${frameworkName}';`; | ||
| virtualModuleMapping[frameworkInitEntry] = `import '${rendererName}';`; |
There was a problem hiding this comment.
Should this be rendererInitEntry?
Base automatically changed from
tom/sb-849-cant-run-the-v6-store-in-sandboxes
to
next
October 25, 2022 04:46
…ocs-only-stories-in-v6 Add new SET_INDEX event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #19594
Issue: v6 store needs to import various client APIs from the renderer not the framework.
What I did
getRendererNameWhat I didn't do:
How to test
Run a sandbox in v6 mode, should work.