Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up vite mdx-plugin #19563

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Tidy up vite mdx-plugin #19563

merged 1 commit into from
Oct 24, 2022

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Oct 20, 2022 •
edited
Loading

Some clean up after #19495

Superseded by #19565

@joshwooding joshwooding requested a review from shilman October 20, 2022 23:59
@JReinhold JReinhold added maintenance User-facing maintenance tasks mdx builder-vite labels Oct 24, 2022
IanVS
IanVS approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step on some cleanup, while we wait for a migration path from stories in mdx.

@IanVS IanVS merged commit 26973f2 into storybookjs:next Oct 24, 2022
@joshwooding joshwooding deleted the tidy-up-vite-mdx-plugin branch October 24, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@IanVS IanVS

Labels
builder-vite maintenance User-facing maintenance tasks mdx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshwooding @IanVS @JReinhold