Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): rename "latest" to "v13" app name in angular v13 repro template #19498

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Oct 15, 2022

What I did#

Both, "latest" and. "v13" created an app that was called "latest".

const angularCliTemplates = {
  'angular-cli/default-ts': {
    name: 'Angular CLI (latest)',
    script:
      'npx -p @angular/cli ng new angular-latest --directory . --routing=true --minimal=true --style=scss --strict --skip-git --skip-install --package-manager=yarn',
   // ...
  },
  'angular-cli/13-ts': {
    name: 'Angular CLI (Version 13)',
    script:
      'npx -p @angular/cli@13 ng new angular-latest --directory . --routing=true --minimal=true --style=scss --strict --skip-git --skip-install --package-manager=yarn',
    // ...
  },
};

I changed "latest" to "angular-v13"

@kroeder kroeder added the maintenance User-facing maintenance tasks label Oct 15, 2022
@kroeder kroeder requested a review from tmeasday October 15, 2022 11:04
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@tmeasday tmeasday merged commit afdf8d0 into next Oct 16, 2022
@tmeasday tmeasday deleted the fix-angular-13-ts-repro-app-name branch October 16, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants