Storybook for Storybook - step 1: ui/manager
#19465
Conversation
| "addons/storyshots/*", | ||
| "frameworks/*", | ||
| "renderers/*", | ||
| "presets/*", | ||
| "examples-native/*", | ||
| "examples/*", | ||
| "examples-native/*", | ||
| "frameworks/*", | ||
| "lib/*", | ||
| "lib/cli/test/run/*" | ||
| "lib/cli/test/run/*", | ||
| "ui/*", | ||
| "presets/*", | ||
| "renderers/*" | ||
| ] |
There was a problem hiding this comment.
added ui/*, ordered all alphabetically
| useTheme, | ||
| } from '@storybook/theming'; | ||
| import { Symbols } from '@storybook/components'; | ||
|
|
There was a problem hiding this comment.
This file is mostly just copied from the old official storybook example. I did however remove the logic for showing warnings about missing env.
| @@ -1,7 +1,7 @@ | |||
| import React, { FC, useMemo } from 'react'; | |||
| import sizeMe from 'react-sizeme'; | |||
|
|
|||
| import { State } from '@storybook/api'; | |||
| import { type State } from '@storybook/api'; | |||
There was a problem hiding this comment.
all of these type imports were just an attempt at fixing eslint warnings
| width, | ||
| ...(mocked ? mockProps : realProps), | ||
| }; | ||
| const props = mocked ? mockProps : realProps; |
There was a problem hiding this comment.
TS correctly complained that height and width were always being overwritten because mockProps and realProps both contain them.
| ); | ||
| return <Zoom key="zoom" {...{ zoomIn, zoomOut, reset }} />; | ||
| }); | ||
| const ZoomWrapper = React.memo<{ set: (zoomLevel: number) => void; value: number }>( |
There was a problem hiding this comment.
butchered diff. the only change here is the better typing of the set function.
JReinhold
changed the title
manager/uimanager/ui
JReinhold
changed the title
manager/uiui/manager
…-604-create-a-standalone-storybook-for-our
| @@ -284,6 +287,7 @@ | |||
| "fs-extra": "^9.0.1", | |||
| "github-release-from-changelog": "^2.1.1", | |||
| "glob": "^7.1.6", | |||
| "global": "^4.4.0", | |||
There was a problem hiding this comment.
I think this dependency was something we were in the process of removing entirely, correct @shilman?
| and adding them back in, but with the `jsxRuntime: 'classic'` option. | ||
| TODO: When we've upgraded to React 18 all of this shouldn't be necessary anymore | ||
| */ | ||
| plugins: [...withoutReactPlugins(config.plugins), vitePluginReact({ jsxRuntime: 'classic' })], |
There was a problem hiding this comment.
Let's (in a follow-up PR) extract this code into the react-vite framework.
We can toggle this behavior in a frameworkOption.
@shilman perhaps this is something we should do this cycle, or the next? And maybe we need a repro for react16+vite, if we do not have one yet.
We could also say react16+vite is unsupported, but that might be a bit too aggressive? (considering we ourselves are using it 🤡
| @@ -0,0 +1,4 @@ | |||
| <script> | |||
| // eslint-disable-next-line no-undef | |||
| window.global = window; | |||
There was a problem hiding this comment.
Let's make it a target for SB7.0 to remove this requirement?
@shilman ☝️ ?
There was a problem hiding this comment.
FYI this is documented here: https://github.com/storybookjs/storybook/tree/next/code/lib/builder-vite#migration-from-webpack--cra
JReinhold
deleted the
jeppe/sb-604-create-a-standalone-storybook-for-our
branch
This PR creates a Storybook for the manager UI.
code/uiwhich will contain multiple packages.lib/uihas been moved toui/manager, but in follow-up PRs we'll movelib/components/,lib/docblocksand maybe alsolib/router.code/ui/.storybookbased onreact/vitewhich will be used forui,components, anddocblocks.The Storybook can be started with
(for now)