Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the old showRoots config option #19440

Merged
merged 3 commits into from
Oct 13, 2022
Merged

remove the old showRoots config option #19440

merged 3 commits into from
Oct 13, 2022

Conversation

ndelangen
Copy link
Member

This removes the option to set showRoots as a top level config item.

It has been moved to the sidebar property since.

@ndelangen ndelangen self-assigned this Oct 11, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks core labels Oct 11, 2022
@ndelangen ndelangen requested a review from tmeasday October 11, 2022 16:07
tmeasday
tmeasday approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 straight into the breach @ndelangen

@ndelangen ndelangen merged commit c42e9a6 into next Oct 13, 2022
@ndelangen ndelangen deleted the deprecate/old-stories-root branch October 13, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees

@ndelangen ndelangen

Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @tmeasday