Addon-docs: Define children for DocsContainer #19437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Explicitly defined children prop for DocsContainer props. In React 18 types, children is not automatically available in FunctionComponent, instead it needs to be explictly added. When trying to override DocsContainer with a component written in TypeScript, with React 18 types installed, it currently throws an error because the internal DocsContainer does not allow children.
Example code that should work without those
@ts-expect-error
comments:Would be nice if this got backported to SB 6.5 as well.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.