Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build builder-webpack5 with ts-up #19435

Merged
merged 27 commits into from
Oct 18, 2022

Conversation

tolkadot
Copy link
Contributor

@tolkadot tolkadot commented Oct 11, 2022

getting the following build warnings :

@storybook/builder-webpack5:

 WARN  ▲ [WARNING] "./presets/preview-preset.ts" should be marked as external for use with "require.resolve" [require-resolve-not-external]

    src/index.ts:264:44:
      264 │ ...t corePresets = [require.resolve('./presets/preview-preset.ts')];
          ╵                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@storybook/builder-webpack5:

 WARN  ▲ [WARNING] "./presets/custom-webpack-preset.ts" should be marked as external for use with "require.resolve" [require-resolve-not-external]

    src/index.ts:265:48:
      265 │ ...resets = [require.resolve('./presets/custom-webpack-preset.ts')];
          ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@ndelangen - Any advice on how to resolve these warnings?

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen changed the title wip: update package.json paths for compatibility with ts-up Build builder-webpack5 with ts-up Oct 17, 2022
@ndelangen ndelangen self-assigned this Oct 17, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 17, 2022
@socket-security
Copy link

socket-security bot commented Oct 17, 2022

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@ndelangen ndelangen marked this pull request as ready for review October 18, 2022 12:00
@ndelangen
Copy link
Member

@tolkadot thank you so much for getting this started. As suspected it wasn't an easy one to do. I hope you don't mind me picking this up and getting it across the line. Well... I hope that's what I did to be honest. CI still needs to approve, and a code-review needs to happen 🙈

@shilman Would you be able to review this?

@ndelangen ndelangen merged commit 7d70d7c into storybookjs:next Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants