Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build command for netlify #19418

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Conversation

ndelangen
Copy link
Member

fix netlify config

@ndelangen ndelangen requested a review from tmeasday October 10, 2022 08:38
@ndelangen ndelangen self-assigned this Oct 10, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 10, 2022
@ndelangen
Copy link
Member Author

@tmeasday we have a missing script now:

10:41:17 AM: Usage Error: Couldn't find a script named "build-storybooks".

So we need to find out what to actually build and upload to netlify.

@tmeasday
Copy link
Member

So we need to find out what to actually build and upload to netlify

We don't have a single script that builds all templates (would we want one anyway, I'm not sure?). We should probably discuss this.

@ndelangen
Copy link
Member Author

I noticed the cd code missing.

As all examples are removed this will eventually become empty, contain nothing, and should therefore be removed.
What to replace it with?

We should discuss that with the DX team perhaps?

I think it doesn't need to be in the monorepo?

In fact come to think of it, we likely have all we need here:
https://github.com/storybookjs/repro-templates-temp/

@tmeasday
Copy link
Member

We definitely need to discuss. Do people want to see our sandbox tests stories in various templates? I'm really not sure.

They likely want to see our two "internal SBs" (one for components, one for blocks). They might want to see some other example "complete" storybooks for other frameworks. But I'm not sure exactly what value the template sandboxes give. Maybe there's value in just the fact that they work, but then maybe the pure repro templates are enough.

@ndelangen
Copy link
Member Author

Whatever we decide to do, we should ensure the CI step isn't broken.

Let's schedule a meeting with some folks of the DX team to figure out how to best replace this.

Base automatically changed from tom/sb-628-properly-document-maintenance-scripts to next October 10, 2022 11:02
@ndelangen ndelangen merged commit fc9ca96 into next Oct 10, 2022
@ndelangen ndelangen deleted the norbert/fix/netlify-config-using-tasks branch October 10, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants