Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open collective notice from storybook install #1940

Merged
merged 2 commits into from
Oct 2, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 2, 2017

Issue: #1938 #1937

What I did

Remove opencollective message

How to test

# build and link
yarn bootstrap && cd lib/cli && yarn link
# use on a sample project
cd && create-react-app cra && cd cra && getstorybook

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested review from Hypnosphi and ndelangen October 2, 2017 16:34
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #1940 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1940   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files         262      262           
  Lines        5757     5757           
  Branches      688      697    +9     
=======================================
  Hits         1231     1231           
+ Misses       4006     3993   -13     
- Partials      520      533   +13
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 41.41% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6e026...85b0eba. Read the comment docs.

@shilman shilman changed the base branch from master to shilman/3.2.12-release October 2, 2017 17:12
@shilman shilman changed the base branch from shilman/3.2.12-release to master October 2, 2017 17:46
@shilman shilman merged commit eeb7dff into master Oct 2, 2017
@shilman shilman deleted the shilman/remove-opencollective branch October 2, 2017 18:04
Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants