-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(angular): drop support for angular < 13 #19368
Conversation
According to the Angular LTS plan, Angular 12 support ends in Nov 2022. A lot of code exists to support Angular < 13 which increases the maintenance effort and decreases the contribution DX of framework/angular. BREAKING CHANGE: Dropped support for Angular 12
c16bb70
to
17bd921
Compare
Example app is running perfectly fine and I think I found every code related to Angular < 13 @ThibaudAV any second thoughts? @ndelangen already agreed to this This is the first PR of a smaller series with the goal to improve the DX for framework/angular in the repo. This also massively decreases the mental load and maintenance effort in the code base |
I think a migration note in |
🚀 Is more easy for many reason and try to support the last one as fast as possible |
Since dropping support is a breaking change, storybook can only do this between major releases. Angular has 2 majors a year and supports the last 3, storybook has about 1 a year, right? So, most likely storybook would need support the last 4 But officially, I totally agree with you! We should only support all lts versions @ndelangen @shilman I don't know with whom I already have discussed this on discord but anyway, should we do this? Only support angular lts? (basically 1 1/2 year of angular code) If yes, where should we document this? |
@ndelangen I added a note to the MIGRATION.md - is this good enough? |
What I did
According to the Angular LTS plan, Angular 12
support ends in Nov 2022. A lot of code exists
to support Angular < 13 which increases the
maintenance effort and decreases the
contribution DX of framework/angular.
This PR removes all code related to Angular < 13 in preparation for Storybook 7.0
How to test
If your answer is yes to any of these, please make sure to include it in your PR.