Docs: Remove STORYBOOK_REACT_CLASSES and global/globals.ts #19300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I could be wrong, but it seems like
STORYBOOK_REACT_CLASSES
isn't actually used anywhere. Though, I found where it was added: #557, and it didn't really seem used there either, so maybe I'm missing something. But, it's adding a bit of extra complexity since this is injected into config viastorybook/code/lib/core-server/src/presets/common-preset.ts
Line 96 in 1041236
In the name of simplifying things, I figured I'd try removing it, and see what happens. But maybe users are relying on this, somehow?
How to test
Maybe an update to the docs?