Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the vue e2e test to use webpack5, since we stopped supporting webpack4 in 7.0 #19257

Merged
merged 11 commits into from
Sep 27, 2022
Merged

change the vue e2e test to use webpack5, since we stopped supporting webpack4 in 7.0 #19257

merged 11 commits into from
Sep 27, 2022

Conversation

ndelangen
Copy link
Member

change how vue2 e2e project is bootstrapped

it should be using webpack5, since webpack4 is no longer supported

@ndelangen ndelangen self-assigned this Sep 26, 2022
@ndelangen ndelangen added run e2e extended test suite Run the e2e extended test suite in CircleCI workflows maintenance User-facing maintenance tasks labels Sep 26, 2022
@ndelangen
Copy link
Member Author

So this doesn't seem to fix the issue @shilman, I'm not sure why.
Some shell parsing error occurs now.

@ndelangen
Copy link
Member Author

@yannbf sadly your suggestion didn't fix this :(
https://app.circleci.com/pipelines/github/storybookjs/storybook/29362/workflows/1709f704-167d-4df8-be98-446736dad612/jobs/415166/parallel-runs/9?filterBy=FAILED

@IanVS IanVS changed the title change the vue e2e test to use webpack5, since we stopped supporting webpack5 in 7.0 change the vue e2e test to use webpack5, since we stopped supporting webpack4 in 7.0 Sep 26, 2022
@ndelangen
Copy link
Member Author

ndelangen commented Sep 26, 2022 •
edited
Loading

Just realized I misread your suggestion @yannbf

trying it proper now.. 🙏

@ndelangen
Copy link
Member Author

Looks like the build is fully working now, but there seems to be some issue with some demo App component:

https://app.circleci.com/pipelines/github/storybookjs/storybook/29376/workflows/c5c9b6b6-f413-406c-ad17-9786231ddaf1/jobs/415363/parallel-runs/9?filterBy=FAILED

https://circleci-tasks-prod.s3.us-east-1.amazonaws.com/storage/artifacts/6c670379-683b-43ce-9651-ba828373e53b/a46d7108-186b-4fd5-aec3-f642b276580a/9/cypress/vue/addon-interactions.spec.ts.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQVFQINEOEPPL5RDQ%2F20220926%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220926T144048Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEEcaCXVzLWVhc3QtMSJGMEQCIQCID5MpzmjG7rkGxqu4rRF8RwDdRJKIDbaEONySdd12oQIffoQcIJLeUTe%2BToO8VaYA49E7aKXK2J%2B7Y8tSQ06%2Faiq0Agjw%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F8BEAMaDDA0NTQ2NjgwNjU1NiIMVrmXlVUBLpAWJkx0KogCcvLsyX2qtGMqy%2B5SGZ0gjmbVXzvxZaVjFgF4QgzvhkWHZ%2BZOU4Wb%2FjxH7b4dHDfrfoa%2Fn8EiNPP3bw8YnLkB3RFJPk591gCfLcTcrPgTQSI9RGrbYDMjNI7QD6vYxbl8inhIF19HxijkrQ%2BR87eo4flMP0Fcv3lKRxSGWT7K7hhjA4hVXPX1OC%2BEDZL%2B6Dhv%2F2M%2FamZczdSGiSdKB2YgW75HasZ6TEi5YotR2n%2Fla17LnbUyHdJBD3eDpv6fPkoASiJIlB8rJsmFp8E2wMjDgexA8hHedauif%2FTLUtCDia9hXixuxRYo%2B%2BfkCcvsitluHyp7wM%2BZuS6HUFh4iirXHatbr0S788%2BLMJbwxpkGOp4B4ZkLyVbRAsZuV6xp3aqt81o%2BIj29N93vqpR0FHJ4uuxBBUiQeHlfSnvh4fVC8AIKTofO6FHagAjET05hvAjUcGOQOlNG7qYxR4jZa%2B4GckQwCJO8draLXIO1pWqpygARMKmHd6h8xnV339l9zKKP5rULc9uHyegIGCcc8nQQzfRCmrVAHL3%2BlB4DsTQHdEkQV7RrbGh5U%2F44SUn9X04%3D&X-Amz-SignedHeaders=host&x-id=GetObject&X-Amz-Signature=ad8aa1a5910f7b3f183811f9384400f4e2f07e2d481b37cdcdcd45aa15fb5565

@ndelangen ndelangen merged commit e8dd2df into next Sep 27, 2022
@ndelangen ndelangen deleted the tech/vue-e2e-fix branch September 27, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndelangen