-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon(info) - wrap prop values in braces #1915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
=======================================
Coverage 21.29% 21.29%
=======================================
Files 261 261
Lines 5743 5743
Branches 694 684 -10
=======================================
Hits 1223 1223
- Misses 3993 3997 +4
+ Partials 527 523 -4
Continue to review full report at Codecov.
|
It looks good to me, what do you think @usulpro @Hypnosphi ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
@ndelangen I think it's rather a bugfix then a feature |
Welcome to the team @bmv437 !! |
Issue:
Based on the code around
braceWrap
I believe the intention was to surround non-string prop values in curly braces. This would make it pretty easy to copy/paste react code from storybook into an app.What I did
I surrounded non-string prop values in html encoded curly braces.
How to test
addon-info "Story Source" used to look like:
now looks like
Is this testable with jest or storyshots?
Yes, with storyshots. I've updated them.
Does this need a new example in the kitchen sink apps?
No.
Does this need an update to the documentation?
No.
If your answer is yes to any of these, please make sure to include it in your PR.