Addon-a11y: Move stories into addon

[ndelangen]

• add generic stories for addon-viewports in code/addons/a11y/template/stories
• remove stories for a11y everywhere else

[tmeasday]

I feel like there are a lot of stories deleted here that we need to figure out how to reimplement somehow. Obviously a11y is tricky as the stories depend on HTML structure, is this blocked by creating an Html component?

[ndelangen]

@tmeasday I argued to @shilman that we should test the things that matter, and are storybook implemented. I think there's no point in testing axe internals.

But yes, I do think this is blocked for now, and likely should not be merged, or if we do, we should create follow-up tasks to ensure we get the proper coverage again.

[ndelangen]

@tmeasday quick question for you about the sandbox script.
So I have the stories show up, but the a11y panel does not show up in the published storybook, and I'm struggling to find why it's not showing up... can you tell me where to look?

https://62f0fd0fd0ff1407689dfeca-xpfmtcuisw.chromatic.com/?path=/story/addons-a11y-parameters--checks&globals=backgrounds.grid:false

I can only see 3: Controls, Actions & Interactions..
But I do not see A11y panel.

[tmeasday]

@ndelangen I think the issue is you added a11y to the set of "default" addons whose stories are linked by the sandbox. But this is supposed to just represent the list of addons that come installed by sb init. If you want to use an addon or stories for an addon that is outside of that list (links, essentials and interactions), you need to pass --addon a11y to the sandbox script. We should probably do that in CI.

[tmeasday]

Addendum to the above, the --addon option doesn't actually work because sb add doesn't work, so for now you need to manually add the addon in main.js (and maybe package.json) to actually test this. 🙈

[tmeasday]

This is pretty close, I just wonder if it might be better to move some of the parameter-based stories to the other file. @ndelangen I'll leave it to you to make the final call!

[tmeasday]

Is it obvious this is doing something? Would it be better to do these kind of things in the HTML-based story file?

[ndelangen]

All right, i think I've improved things a bit, will merge when green!