Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: remove outdated comment in Angular starter #19097

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 2, 2022

Issue: N/A

What I did

There was a comment in the angular CLI starter mentioning Storybook 6.1 🙈

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added maintenance User-facing maintenance tasks cli labels Sep 2, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 5, 2022
@shilman shilman merged commit 4c4459d into next Sep 5, 2022
@shilman shilman deleted the fix/cleanup-comment branch September 5, 2022 16:38
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants