Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc blocks: Update ArgTable Reset button to use IconButton #19052

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

MichaelArestad
Copy link
Contributor

What I did

ArgTable currently has a unique button design. This change updates to use Storybook's IconButton component.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@MichaelArestad MichaelArestad added maintenance User-facing maintenance tasks block: argstable labels Aug 29, 2022
@MichaelArestad MichaelArestad self-assigned this Aug 29, 2022
@MichaelArestad MichaelArestad marked this pull request as ready for review August 30, 2022 14:35
@domyen
Copy link
Member

domyen commented Sep 2, 2022

lgtm

@shilman shilman changed the title Update ArgTable Reset button to use IconButton Doc blocks: Update ArgTable Reset button to use IconButton Sep 7, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 💯

@shilman shilman merged commit 109551b into next Sep 7, 2022
@shilman shilman deleted the update-controls-reset-button branch September 7, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: argstable maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants