-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix polyfills loading order #1905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1905 +/- ##
=======================================
Coverage 21.31% 21.31%
=======================================
Files 257 257
Lines 5737 5737
Branches 693 685 -8
=======================================
Hits 1223 1223
- Misses 3990 4002 +12
+ Partials 524 512 -12
Continue to review full report at Codecov.
|
Looks good, but will this help with the issue we're having in 3.3? |
That's exactly what it addresses. In 3.3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making a mental note to revisit this code later, because this code looks super fishy to me.
I would prefer to not have to inject entry points like this.
If you've tested this @Hypnosphi go ahead and merge! |
One possible alternative is to |
Issue:
addons.js
is loaded before polyfills inmanager
entry, which leads to issues in IE.What I did
I put
addons.js
right after the polyfillsHow to test
Open React and Vue kitchen sink apps in IE11