-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix WebProjectAnnotations export in preview-web for back-compat #19048
Core: Fix WebProjectAnnotations export in preview-web for back-compat #19048
Conversation
@shilman this is what we talked about in discord. I'm not sure what's needed to get CI running/passing. I attempted to start a discussion in https://discord.com/channels/486522875931656193/839297503446695956/1013924170918269008. |
@tmeasday the background here is that a type got moved as a breaking change in 6.5. This re-exports the type to fix the break, which affects the test runner specifically. Questions:
|
I'm going to test this fix this afternoon in our PR, and post back here, (in case there's something else blocking). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @clintandrewhall !! 🙏
Fine by me, to re-export it. I'm not totally sure I recall why it moved in the first place, but either way re-exporting makes sense to avoid breaking in any case. |
Guys please help
…On Wed, 31 Aug, 2022, 9:32 am Tom Coleman, ***@***.***> wrote:
Fine by me, to re-export it. I'm not totally sure I recall why it moved in
the first place, but either way re-exporting makes sense to avoid breaking
in any case.
—
Reply to this email directly, view it on GitHub
<#19048 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARYHGOF7XFH5YG6ISRERD4DV33KMVANCNFSM576R7LUA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@shilman you fixed this in the latest alpha release. Is it possible to fix this for a stable version? |
It has the |
Core: Fix WebProjectAnnotations export in preview-web for back-compat
Issue: storybookjs/testing-react#106
Discussion: #18531
What I did
I added a type export to resolve. It was unclear if this, too, would affect
builder-vite
, (I can't imagine it would), but I added the export immediately following for visibility and completeness.Hope this helps!
How to test
Is this testable with Jest or Chromatic screenshots?Does this need a new example in the kitchen sink apps?Does this need an update to the documentation?If your answer is yes to any of these, please make sure to include it in your PR.