Vite: Clean up framework dependencies / unused files #19035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
added
dependencies
maintenance
|
@IanVS Any idea what's up with the failing smoke tests? |
|
I can't see how the changes here could have broken CRA, so I'm tempted to call it flake. I'll rebase and push a commit to see if it happens again. |
These match up with vite 3's current requirements
IanVS
force-pushed
the
vite-framework-deps
branch
from
e2fb0af to
0cb5f7c
Compare
|
Yep, seems like it was flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Similar to #19025, this cleans up unused dependencies in
svelte-viteandvue3-vite. It also:enginesto match vite's requirementsHow to test
CI should pass
If your answer is yes to any of these, please make sure to include it in your PR.