Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add react, vue3, and svelte vite to new-frameworks automigration #19016

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 25, 2022

Issue: N/A

What I did

Now that we have @storybook/react-vite, @storybook/vue3-vite, @storybook/svelte-vite,I added support for these packages in the new-frameworks automigration.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf force-pushed the feat/vite-frameworks-automigration branch from 3f9b825 to bbffe7d Compare August 25, 2022 16:37
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🤩

@shilman shilman changed the title CLI: add react and vue3 vite to new-frameworks automigration CLI: Add react and vue3 vite to new-frameworks automigration Aug 26, 2022
@yannbf yannbf force-pushed the feat/vite-frameworks-automigration branch from a634dc9 to 5d1fd31 Compare August 26, 2022 08:26
@shilman shilman changed the title CLI: Add react and vue3 vite to new-frameworks automigration CLI: Add react, vue3, and svelte vite to new-frameworks automigration Aug 26, 2022
@shilman shilman merged commit 090e1aa into next Aug 26, 2022
@shilman shilman deleted the feat/vite-frameworks-automigration branch August 26, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants