Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Remove unused bootstrap --cleanup #18981

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Build: Remove unused bootstrap --cleanup #18981

merged 1 commit into from
Aug 22, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 22, 2022 •
edited
Loading

Issue: N/A

What I did

Remove bootstrap --cleanup:

  • It's redundant now because we clear dist in build --prep
  • It was buggy and deleted dist folders from node_modules

Self-merging @ndelangen @yannbf

How to test

  • CI passes

@shilman shilman added the maintenance User-facing maintenance tasks label Aug 22, 2022
@shilman shilman merged commit 9ed59d8 into next Aug 22, 2022
@shilman shilman deleted the shilman/remove-unused-cleanup branch August 22, 2022 10:10
@shilman shilman mentioned this pull request Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman