Replace rollup-plugin-node-polyfills to analogs #18975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#17019 (related)
What I did
Replace package
rollup-plugin-node-polyfills
toprocess
andutil
.Why:
When a storybook is installed, among other things, I get this warning:
I decided to unwind this story.
Looking at the code as well, I found out that the Storybook only relies on a few polyfills, not the entire package from
rollup-plugin-node-polyfills
.Looking at the package code, I noticed that it is similar to the
node-polyfill-webpack-plugin
, but unlike the latter, it comes with its own polyfills.I replaced the polyfills from
rollup-plugin-node-polyfills
with polyfills that are in separate packages (as happens innode-polyfill-webpack-plugin
). I also skimmed through their code and found the polyfills to be very similar (except for the import formats).In addition to the fact that now users will not receive warning, the Storybook will rely on packages that are much more popular in terms of downloads than the current one.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.