-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Automigration for new frameworks #18919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a7f3904.
tmeasday
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions but it looks great!
shilman
changed the title
CLI: auto migration for new frameworks
CLI: Automigration for new frameworks
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
This PR adds a new automigration to go from older framework format to the new framework format, such as:
from
to
And also make the necessary changes in main.js. There's a limitation currently because the csf-tools don't provide a way to delete keys, so if
core
was supposed to be deleted, instead it's turned into an empty object.I tested this in different frameworks and it works great, we can finally have a migration from 6.0 to 7.0 that works right after 👯
A few pics:
Yea, formatting is a slight issue, but we can't do much about it 🤷
How to test
If your answer is yes to any of these, please make sure to include it in your PR.