CLI: install the same version as the user in sb-scripts automigration #18917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was installing latest, which could result in a wrong situation
ndelangen
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
The sb-scripts were doing a couple things that could result in a wrong structure in users' projects:
storybook@latestThis PR fixes both scenarios to:
storybook@<specifier>The comes from a new utility called
getStorybookVersionSpecifierwhich will install the lib with the same specifier as the one from other @storybook packages. This is assuming that the @storybook packages are consistent when running this migration (something we will work on later to make sure it's always right)How to test
If your answer is yes to any of these, please make sure to include it in your PR.