Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create export for lib/theming, proper #18906

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

ndelangen
Copy link
Member

This is actually kind of a good idea, because of the size of lib/theming/index

This is actually kind of a good idea, because of the size of lib/theming/index
@ndelangen ndelangen requested a review from yannbf August 9, 2022 12:26
@ndelangen ndelangen self-assigned this Aug 9, 2022
@yannbf
Copy link
Member

yannbf commented Aug 9, 2022

Is this a breaking change? If not, is this preferred over import { create } from '@storybook/theming'?

@ndelangen
Copy link
Member Author

I'm effectively reverting the breaking change @yannbf
Yes this is preferred over importing it from the main entry, especially in the manager.ts file.

@ndelangen ndelangen merged commit 2a45b19 into next Aug 10, 2022
@ndelangen ndelangen deleted the tech/bring-back-theming-create branch August 10, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants