Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix canvas support expand code for non-story #18808

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

youngboy
Copy link
Contributor

@youngboy youngboy commented Jul 28, 2022

Issue:

option withSource="open" describe in https://storybook.js.org/docs/react/writing-docs/doc-block-canvas not work for non-story content

What I did

How to test

<Canvas withSource="open">
  <h2>Some here</h2>
</Canvas>
  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks, @youngboy!

And congratulations on your first contribution! 🥳

/cc @shilman

@shilman shilman changed the title fix: canvas support expand code for non-story Addon-docs: Fix canvas support expand code for non-story Aug 22, 2022
@shilman shilman merged commit 457b9f9 into storybookjs:next Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants