-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte: don't add svelte-loader
nor svelte
when initializing Svelte projects
#18799
Conversation
svelte-loader
should not be added to all Svelte projects
@j3rem1e can you please review this when you get a chance? |
2e1fbf6
to
514ed31
Compare
Isn't this superseded by #19263 by @IanVS, that only adds the Or do we not want to add the loader at all, because we assume webpack setups already have that? If they already have that then this won't make a difference though, right? I haven't tried any of this out, but my hunch tells me that we shouldn't add any extra packages at all, because we can assume that they're already there, since they are actually essential packages and not extra packages. |
I would assume both svelte-loader and Svelte are already present and agree we shouldn't need to add either of them. I've updated this PR accordingly |
svelte-loader
should not be added to all Svelte projectssvelte-loader
nor svelte
when initializing Svelte projects
What I did
svelte-loader
should not be added indiscriminately. It is only needed for webpack projects, but Svelte projects use Vite by default, so it's mostly wrong to add it. Users will have set this up already if they're using Svelte and webpackHow to test
If your answer is yes to any of these, please make sure to include it in your PR.