-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to channel that ignores event from self #1879
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1879 +/- ##
===============================================
- Coverage 21.98% 21.74% -0.24%
===============================================
Files 338 355 +17
Lines 6700 7059 +359
Branches 880 917 +37
===============================================
+ Hits 1473 1535 +62
- Misses 4556 4833 +277
- Partials 671 691 +20
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1879 +/- ##
===============================================
+ Coverage 22.74% 22.77% +0.03%
===============================================
Files 326 326
Lines 6750 6753 +3
Branches 847 843 -4
===============================================
+ Hits 1535 1538 +3
- Misses 4603 4604 +1
+ Partials 612 611 -1
Continue to review full report at Codecov.
|
005fb0f
to
96daaa8
Compare
Issue: #1407
Since we don't check for sender it's hard to know from where the event comes
What I did
Add
addPeerListener(type, listener)
method, that keeps previous behaviorHow to test
yarn jest -- lib/channels/