-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future - Move all code into a code
directory
#18759
Conversation
… jest transformer, fix ref to examples in smoke-tests
… in tests script in the monorepo.
# Conflicts: # code/addons/a11y/package.json # code/examples/preact-kitchen-sink/package.json # code/lib/blocks/package.json # code/yarn.lock # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM!
# Conflicts: # .vscode/launch.json # CONTRIBUTING.old.md # code/lib/cli/tsconfig.json # scripts/tsconfig.json
Just in case this was not intended, this brings a tiny problem with some links in the Storybook UI: Some of them explicitly target the The above link points at https://github.com/storybookjs/storybook/blob/next/addons/interactions/README.md which is now a broken link since this was merged into the Now, if this was not ignored on purpose, is it even important? I mean:
|
The link should be fixed in the next alpha release. |
Move all the code in the monorepo to a sub-directory called
code
.Why?
We do this because we plan to be able to work on repros inside the monorepo.
We want to be able to quickly spawn a repro-template, link it up with the monorepo packages, and work on it / test it.
This spawned template should not inherit anything from the monorepo other than the packages in the monorepo itself; the instance should be as self-sufficient as can be.
Some examples of what we try to avoid:
@types/react
, because it's installed in the monorepo for various things. This can cause major conflicts.So the idea is to move everything code related to
code
and keepdocs
,media
(should probably move this out?) andscripts
in the root.Right now there is no
package.json
ornode_modules
in the root of the project. This is very much intended!Though, I have to think about how to invoke scripts from the root.
Todo
/scripts
and/code
, I think there's a lot of overlap here./scripts
and/code
, I think/scripts/package.json
needs none./code
and/scripts
..yarn
to the root to a custom directory, so it's not picked up by default, but can be shared between/scripts
and/code
.