-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview: Simplify docsMode #18729
Preview: Simplify docsMode #18729
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit efea215. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
}, | ||
layout: { | ||
initialActive: ActiveTabs.CANVAS, | ||
showToolbar: !DOCS_MODE, | ||
showToolbar: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toolbar will hide automatically as all entries are docs
if (DOCS_MODE) { | ||
api.jumpToComponent(direction); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens naturally as all entries are docs, we don't have to skip over any.
@@ -10,7 +10,6 @@ beforeEach(() => { | |||
currentState = { | |||
ui: { | |||
enableShortcuts: true, | |||
docsMode: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We weren't using this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change! 🎉
Telescoping on #18728What I did
docs
from the indexDOCS_MODE
global and instead use props from the providerHow to test
Run react-ts in docs mode and without.
We don't have any e2e tests for docs mode at this stage 😞