Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for custom packager port #1837

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Added option for custom packager port #1837

merged 1 commit into from
Sep 13, 2017

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Sep 13, 2017

Issue: #1367

What I did

Added option for custom packager port (--packager-port=xxxx) .

How to test

Pass option --packager-port and see that new port is used.

Is this testable with jest or storyshots?
RN cli is not tested with jest yet.

Does this need a new example in the kitchen sink apps?
No.

Does this need an update to the documentation?
Not sure. We should document all the options available in cli.

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #1837 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1837      +/-   ##
==========================================
+ Coverage   21.32%   21.33%   +<.01%     
==========================================
  Files         257      257              
  Lines        5739     5737       -2     
  Branches      686      686              
==========================================
  Hits         1224     1224              
+ Misses       3981     3979       -2     
  Partials      534      534
Impacted Files Coverage Δ
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f73119...be88c0b. Read the comment docs.

@ndelangen
Copy link
Member

If you have tested this @Gongreg, go ahead and merge.

@Gongreg Gongreg merged commit 4a94cc5 into master Sep 13, 2017
@Gongreg Gongreg deleted the rn-packager-port branch September 13, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants