Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest to the latest version 🚀 #1799

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Conversation

ndelangen
Copy link
Member

Issue: #1796

What I did

Fixed the jest incompatibility with mock-fs by switching to jest.mock()

How to test

Unit tests should pass

@ndelangen ndelangen self-assigned this Sep 5, 2017
@ndelangen ndelangen requested a review from Hypnosphi September 5, 2017 22:40
@ndelangen ndelangen changed the title Greenkeeper/jest 21.0.1 Update jest to the latest version 🚀 Sep 5, 2017
@codecov
Copy link

codecov bot commented Sep 5, 2017

Codecov Report

Merging #1799 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
+ Coverage   21.14%   21.21%   +0.07%     
==========================================
  Files         252      252              
  Lines        5693     5693              
  Branches      686      686              
==========================================
+ Hits         1204     1208       +4     
+ Misses       3970     3967       -3     
+ Partials      519      518       -1
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-32.15%) ⬇️
app/vue/src/server/babel_config.js 77.41% <0%> (-6.46%) ⬇️
app/vue/src/server/utils.js 53.57% <0%> (+53.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4966a71...14cc324. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen
Copy link
Member Author

If you're approving, please just go ahead and merge.

@ndelangen ndelangen merged commit a8c5720 into master Sep 5, 2017
@ndelangen ndelangen deleted the greenkeeper/jest-21.0.1 branch September 5, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants