Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook-chrome-screenshot to addon gallery #1761

Merged
merged 4 commits into from
Aug 30, 2017

Conversation

wadackel
Copy link
Contributor

Issue: none

What I did

Add storybook-chrome-screenshot addon to addon gallery.

How to test

$ cd docs
$ npm run dev
$ open http://localhost:8000/addons/addon-gallery/

@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #1761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1761   +/-   ##
=======================================
  Coverage   21.14%   21.14%           
=======================================
  Files         252      252           
  Lines        5693     5693           
  Branches      681      689    +8     
=======================================
  Hits         1204     1204           
+ Misses       3983     3954   -29     
- Partials      506      535   +29
Impacted Files Coverage Δ
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37ae4c...c3a4097. Read the comment docs.

@danielduan
Copy link
Member

I undid the changes that the automatic linter scripts made to the title. Should be good to go.

@wadackel
Copy link
Contributor Author

Hi @danielduan , Thanks for reviewed.
And sorry. I unexpectedly changed the title ...

@kazupon
Copy link
Member

kazupon commented Aug 30, 2017

@tsuyoshiwada welcome to storybook 😉

@wadackel
Copy link
Contributor Author

Hi @kazupon, Thx 😃 !

@Hypnosphi Hypnosphi self-assigned this Aug 30, 2017
@Hypnosphi Hypnosphi merged commit b474cbd into storybookjs:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants