Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install @storybook/react-native in RN getstorybook #1741

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 26, 2017

Issue: #1738

What I did

Fixes a bug introduced in #1652 where @storybook/react-native is no longer being installed by getstorybook for RN projects.

How to test

yarn bootstrap -- --core
cd ..
yarn create react-native-app crna
cd crna
../storybook/node_modules/\@storybook/cli/bin/generate.js
yarn storybook

Is this testable with jest or storyshots? No

Does this need a new example in the kitchen sink apps? No

Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested a review from a team August 26, 2017 07:52
@codecov
Copy link

codecov bot commented Aug 26, 2017

Codecov Report

Merging #1741 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1741   +/-   ##
=======================================
  Coverage   21.18%   21.18%           
=======================================
  Files         252      252           
  Lines        5694     5694           
  Branches      695      695           
=======================================
  Hits         1206     1206           
  Misses       3948     3948           
  Partials      540      540

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed35cf3...82a40af. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable although I have not ran the code

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no-brainer

@shilman shilman merged commit da2621d into master Aug 26, 2017
@shilman shilman deleted the 1738-react-native-getstorybook-bug branch August 26, 2017 15:35
@shilman shilman restored the 1738-react-native-getstorybook-bug branch August 26, 2017 15:41
@shilman shilman deleted the 1738-react-native-getstorybook-bug branch August 26, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants