-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to select an addon panel && rename selectedDownPanel to selectedAddonPanel #1641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 21.3% 21.41% +0.11%
==========================================
Files 244 244
Lines 5384 5402 +18
Branches 665 667 +2
==========================================
+ Hits 1147 1157 +10
- Misses 3732 3735 +3
- Partials 505 510 +5
Continue to review full report at Codecov.
|
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For the record (for those googling |
Issue: #811
we had
selectedDownPanel
option in our UI module but it wasn't available bysetOptions
What I did
Allow to set
selectedDownPanel
bysetOptions
.Now it's possible to select the spesific addon panel this way:
You need to pass a panel ID to select a panel (same value that you pass to
addons.addPanel()
)If you don't know the ID you can pass anything and find in the console output the list of all registered
panels
How to test
run
cra-kitchen-sink
Check out "Button" section. Selecting stories with different addons you'll see appropriate addon panels auto selected
Try to pass
null
or something else.