-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebarAnimations config prop #1601
Add sidebarAnimations config prop #1601
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
==========================================
- Coverage 21.05% 20.42% -0.63%
==========================================
Files 244 241 -3
Lines 5311 5254 -57
Branches 669 666 -3
==========================================
- Hits 1118 1073 -45
+ Misses 3670 3654 -16
- Partials 523 527 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In fact, we can think about using CSS transitions instead of JS animation provided by react-treebeard to make things less laggy with heavy stories. But an ability to completely opt out of animations won't hurt anyway |
whether it will lead to the fact that in the future we will have a bunch of options for tweaking UI? I guess we'll able to provide the same options via UI components when it's ready |
Indeed @usulpro |
Issue:
What I did
add option
sidebarAnimations
which allows to disable sidebar tree animation. By default animations are enabledHow to test