Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FAQ entry for shared config with next #1390

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Conversation

tmeasday
Copy link
Member

Issue: It's not trivial to reuse config between next and SB, this adds an example

@codecov
Copy link

codecov bot commented Jun 30, 2017

Codecov Report

Merging #1390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1390   +/-   ##
=======================================
  Coverage   14.35%   14.35%           
=======================================
  Files         201      201           
  Lines        4613     4613           
  Branches      519      497   -22     
=======================================
  Hits          662      662           
- Misses       3501     3532   +31     
+ Partials      450      419   -31
Impacted Files Coverage Δ
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/WrapStory.js 12% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638392c...5950777. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 6df3dea into master Jun 30, 2017
@ndelangen ndelangen deleted the tmeasday-patch-1 branch July 8, 2017 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants