Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we add the correct version of react-dom #1349

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

tmeasday
Copy link
Member

Issue: #1284

We need to use an equal version to the react version the app is using.

What I did

Looked in package.json#dependencies.

We could also look elsewhere (e.g. devDependencies), but that's where RN will put it.

How to test

cd /tmp
react-native init App
cd App
# ensure this is npm-linked
getstorybook
npm run storybook

@shilman maybe can test CRNA too?

We need to use an equal version to the `react` version the app is using.

#1284
@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #1349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   13.76%   13.76%           
=======================================
  Files         202      202           
  Lines        4621     4621           
  Branches      598      507   -91     
=======================================
  Hits          636      636           
- Misses       3473     3552   +79     
+ Partials      512      433   -79
Impacted Files Coverage Δ
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6faea...928ea5e. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is also where CRNA puts it.

@shilman shilman merged commit 6696fe2 into master Jun 23, 2017
@shilman shilman deleted the 1284-hardcoded-react-dom-version branch June 23, 2017 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants