-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Storybook release process #1348
Conversation
these bugs get addressed. | ||
|
||
For every non-PATCH release, we nominate a small number of bugs that must be | ||
addressed before a release can go out by adding them to the milestone. For example, here's a list of blocking bugs [for the 3.2 milestone](https://github.com/storybooks/storybook/milestone/3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this link broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all open issues in the 3.2 milestone, but I think that's OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was wrong, I just eyeballed and though it was supposed to say ..../3.2
RELEASES.md
Outdated
If you're experiencing a bug, the best way to make sure that it gets attention | ||
is to upvote it by adding a "thumbs-up" reaction in Github. This way important | ||
bugs quickly bubble to the top [with a | ||
search](https://github.com/storybooks/storybook/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this link to filter out non-bug
s, fixed
bugs, bugs with a milestone, etc
RELEASES.md
Outdated
- For PATCH changes, all discussion can occur in issue/PR comments (and random slack chat as needed). | ||
- For MINOR feature changes, there are multiple stages of discussion: | ||
- The feature may be discussed in an issue before it is implemented (ex: <https://github.com/storybooks/storybook/issues/151>) | ||
- Once it's implemented, the discussion may be occur on the PR (ex: <https://github.com/storybooks/storybook/issues/151>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a PR link?
Codecov Report
@@ Coverage Diff @@
## master #1348 +/- ##
========================================
Coverage ? 14.1%
========================================
Files ? 201
Lines ? 4609
Branches ? 512
========================================
Hits ? 650
Misses ? 3516
Partials ? 443 Continue to review full report at Codecov.
|
@tmeasday thanks for catching the typos. added a |
LGTM! Might want to wait for a couple more approvals to this process change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RELEASES.md
Outdated
# Release Process | ||
|
||
A Storybook release process based on [Semver](http://semver.org/). In short: | ||
1\. merge bugfix PRs directly into master automatically release (~daily) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would end the lines here for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandrebodin thanks. some weird linting auto-fix 😄
Looks good to me! |
Issue: N/A
What I did
Document our release/decision-making process initially for discussion purposes, and finally as a reference so we have some standards about this for our releases.
How to test
N/A