Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a pack -> install technique to recreate local packages #1332

Merged
merged 3 commits into from
Jun 22, 2017

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 22, 2017

As suggested by npm/npm#15900. This is a workaround until we get a better resolution of #1286

Issue: #1331

What I did

Added a build-packs command that builds a pack (this is what npm does right before publishing) for each of our packages, and moves them to packs/$name.tgz (note, no version number).

test-cra depends on those packs directly, which recreates the old npm<5 local package install.

How to test

npm install
npm run bootstrap
# you may need to clear out node_modules first
npm run bootstrap:test-cra
npm run bootstrap:react-native-vanilla

# this should pass! (+ in CI)
npm test

# also, test that the app works
cd examples/test-cra
npm start
npm run storybook

@tmeasday tmeasday requested a review from shilman June 22, 2017 01:46
@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (1266-fix-components-deps@e5041fa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             1266-fix-components-deps    #1332   +/-   ##
===========================================================
  Coverage                            ?   13.75%           
===========================================================
  Files                               ?      202           
  Lines                               ?     4623           
  Branches                            ?      522           
===========================================================
  Hits                                ?      636           
  Misses                              ?     3516           
  Partials                            ?      471

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5041fa...45300c3. Read the comment docs.

@tmeasday tmeasday force-pushed the 1331-test-cra-on-tarballs branch from 41c1b60 to 45300c3 Compare June 22, 2017 02:20
@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@shilman shilman added the maintenance User-facing maintenance tasks label Jun 22, 2017
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome sauce! this is a little weird, but then again so is npm 😝

@shilman shilman merged commit d1b625a into 1266-fix-components-deps Jun 22, 2017
@Hypnosphi Hypnosphi deleted the 1331-test-cra-on-tarballs branch August 17, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants