-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings for links add-on #1154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1154 +/- ##
=======================================
Coverage 12.75% 12.75%
=======================================
Files 199 199
Lines 4571 4571
Branches 724 724
=======================================
Hits 583 583
Misses 3347 3347
Partials 641 641 Continue to review full report at Codecov.
|
Looks good to me, You seem to use and or know a bit about typescript. Looks like that's another way of providing type definitions besides pushing it to your own package and thus all consumers? Thanks for this PR! |
@ndelangen Yes, this scope is populated via: https://github.com/DefinitelyTyped/DefinitelyTyped/ which is the de-facto standard way to consume types for untyped packages. We could easily transfer all the included typings in this repo into definitely typed - I actually think that might be favourable, as we can make sure that the type definitions are kept up-to-date by more people, are more easily discoverable and can be installed optionally. |
Cool, can you help us with this? What do you need from us / what do we need to do to make this work ? |
First step is to open the PRs in definitely typed for the packages that currently have types. It usually takes a bit longer for new packages to be accepted. Then once we have a release in |
I can start that process without any additional help I think - we just need to make sure that we keep the typings in sync during this process. |
With your help, that should be do-able right? 😃 |
Awesome @joscha!! I'm sure we can come up with some smart way to ensure the types are up to date ... Right @ndelangen ;-) |
Issue:
storybook-addon-links
can't be used from Typescript.What I did
Added Typescript typings for
storybook-addon-links
.How to test
n/a