Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings for links add-on #1154

Merged
merged 2 commits into from
May 30, 2017
Merged

Add typings for links add-on #1154

merged 2 commits into from
May 30, 2017

Conversation

joscha
Copy link
Member

@joscha joscha commented May 30, 2017

Issue: storybook-addon-links can't be used from Typescript.

What I did

Added Typescript typings for storybook-addon-links.

How to test

n/a

@codecov
Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   12.75%   12.75%           
=======================================
  Files         199      199           
  Lines        4571     4571           
  Branches      724      724           
=======================================
  Hits          583      583           
  Misses       3347     3347           
  Partials      641      641

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe882f9...d37adc7. Read the comment docs.

@ndelangen
Copy link
Member

ndelangen commented May 30, 2017

Looks good to me,

You seem to use and or know a bit about typescript.
Can you tell me what this @types/xyz is on npm?
https://www.npmjs.com/~types

Looks like that's another way of providing type definitions besides pushing it to your own package and thus all consumers?

Thanks for this PR!

@ndelangen ndelangen merged commit 8e955b1 into storybookjs:master May 30, 2017
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label May 30, 2017
@ndelangen ndelangen added this to the v3.0.0 milestone May 30, 2017
@joscha
Copy link
Member Author

joscha commented May 30, 2017

Looks like that's another way of providing type definitions besides pushing it to your own package and thus all consumers?

@ndelangen Yes, this scope is populated via: https://github.com/DefinitelyTyped/DefinitelyTyped/ which is the de-facto standard way to consume types for untyped packages. We could easily transfer all the included typings in this repo into definitely typed - I actually think that might be favourable, as we can make sure that the type definitions are kept up-to-date by more people, are more easily discoverable and can be installed optionally.

@joscha joscha deleted the patch-1 branch May 30, 2017 05:49
@ndelangen
Copy link
Member

Cool, can you help us with this? What do you need from us / what do we need to do to make this work ?

@joscha
Copy link
Member Author

joscha commented May 30, 2017

First step is to open the PRs in definitely typed for the packages that currently have types. It usually takes a bit longer for new packages to be accepted. Then once we have a release in @types/xxx we can remove the typings in this repo for xxx.

@joscha
Copy link
Member Author

joscha commented May 30, 2017

I can start that process without any additional help I think - we just need to make sure that we keep the typings in sync during this process.

@ndelangen
Copy link
Member

With your help, that should be do-able right? 😃

@shilman
Copy link
Member

shilman commented May 30, 2017

Awesome @joscha!! I'm sure we can come up with some smart way to ensure the types are up to date ... Right @ndelangen ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants