-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge docs repo into this repo: add /docs #1131
Conversation
- point references to appropriate monorepo sub packages - update storybook / react-scripts versions - remove storybook hub links
Monorepo/storybooks.js.org doc update
Setup publish npm script
Clean up monorepo links
Fix SPA deep-linking problem
Links used to be an add-on, but are now supported natively in storybook. Updated the docs to reflect that.
Add StoryRouter to the addon gallery
Update linkTo documentation
When we moved to github pages, we moved the doc source to `source` branch, and the `npm run publish` script force pushes the built site to the `master` branch.
Work in progress: ported storybooks content Still needs: - two-level nav hierarchy - styling improvements - stories ;-)
Add note about webpack version
Fix edit this page link
Added PR template similar to storybook repo
Use index.md so that images show properly in github, e.g.: ```md ![Login Form](../static/login_form.png) ```
@mnmtanish @shilman @mthuret Would you like to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Fingers crossed!
@@ -21,22 +21,19 @@ | |||
}, | |||
"homepage": "https://github.com/storybooks/storybook/tree/master/addons/actions", | |||
"devDependencies": { | |||
"@storybook/addons": "^3.0.0-rc.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to docs, but we'll let it slide 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndelangen Is there a chance that you can remember why was it needed to move @storybook/addons
frop peerDeps to direct deps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely 0 chance of me remembering, sorry.
Though I think it makes sense, and without lock-files would work great.
Having these lockfiles really messes up the singleton module method, which lib/addons depends on to function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without lock-files would work great
But it's probably the only reason users have to use the same patch version for all the @storybook
dependencies (regardless of whether do they use lockfile)
It would appear like a deploy to gh-pages wasn't succesful, can you look into it @shilman |
/docs
/docs
Issue:
What I did
How to test
It's already deployed to http://storybook.js.org