Fix CLI had a package version from storybook hardcoded - now queries npm registry #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theinterned @mnmtanish @danielduan Can you review? |
danielduan
approved these changes
May 20, 2017
ndelangen
changed the title
ndelangen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1077
What I did
I changed the way the cli determines what is the latest version of the packages it should install.
Before it was hard-coded, now it actually consults the registry.
How to test
npm i ./cli -ggetstorybook -VgetstorybookI tested:
The above steps. The project I tested on already had storybook, this gave expected feedback. I was able to force it using
--force. I think this is enough to be sure it works.