CHANGE folder structure && CHANGE package-names

[ndelangen]

What I did

I implemented the proposed changes to the folder structure and package names

[shilman]

@ndelangen when i try to test it, I get this error:

lerna ERR! execute npm ERR! 404 Not found : @storybook/storybook-database-cloud
lerna ERR! execute npm ERR! 404 
lerna ERR! execute npm ERR! 404  '@storybook/storybook-database-cloud' is not in the npm registry.
lerna ERR! execute npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

It is referenced by addon-comments. I think we should either migrate database-* to the monorepo, revert to @kadira/database-cloud, or remove addon-comments from the monorepo for now.

[shilman]

FYI all of these are going to conflict with the changes I made in #1017

[ndelangen]

Yup I'll correcting it.

[usulpro]

Thanks, @ndelangen for this rearrangement! 👍

Some points to discuss:

• rename decorator-centered to addon-centered since this is also an addon. (We don't have special names for panels, storiesOf extensions).

• move storyshots to addons folder. Since we import it additionally we can call it "addon"

• changing packages to lib looks good to me, but maybe core also could fit?

• what is the purpose of the app folder? Maybe it should be located in the examples\ folder?

[ndelangen]

App folder are the what previously were @kadira/storybook and @kadira/storybook-react-native

In the future there may be other UI libraries/frameworks there too.

[codecov]

Codecov Report

Merging #1031 into am-change-npm-organisation will decrease coverage by 12.57%.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           am-change-npm-organisation   #1031       +/-   ##
==============================================================
- Coverage                       12.57%      0%   -12.58%     
==============================================================
  Files                             200       6      -194     
  Lines                            4478      25     -4453     
  Branches                          714       6      -708     
==============================================================
- Hits                              563       0      -563     
+ Misses                           3283      19     -3264     
+ Partials                          632       6      -626

Impacted Files	Coverage Δ
...ges/storyshots/stories/directly_required/Button.js
...ganisation-name/update-organisation-name.output.js
...ackages/react-storybook/demo/src/stories/Button.js
...ts/stories/required_with_context/Button.stories.js
...book-ui/src/modules/ui/components/layout/usplit.js
...orybook-ui/src/modules/ui/containers/left_panel.js
packages/getstorybook/lib/project_types.js
packages/storyshots/src/storybook-channel-mock.js
...s/storybook-ui/src/modules/api/configs/init_api.js
packages/storybook-ui/example/server.js
... and 45 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d2e21...bd95b6e. Read the comment docs.

[shilman]

I agree with @usulpro 's comments above. Otherwise, the changes look good to me. Thanks for all your work on getting this cleaned up!!

[tmeasday]

Do we want to change storyshots to @storybook/storyshots?

[ndelangen]

I just want to get this finished and merged, so just shout how you want it now, or forever hold your peace 🙊

[ndelangen]

I will continue work on the other branch!

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bd95b6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.