Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Fix flexbox style bugs #64

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Fix flexbox style bugs #64

merged 1 commit into from
Nov 30, 2016

Conversation

bluetidepro
Copy link
Contributor

@bluetidepro bluetidepro commented Nov 29, 2016

Changes:

  • Fixes bug with down_panel flexbox (see below)
  • Fixes spacing/alignment bug in left panel (see below)
  • Updates Changelog.md
  • Bumps version to 3.7.1

Down Panel:

As is (With width not set, broken):

Fix (With width set to 100%):

Left Panel:

As is (broken alignment):

Fix:

@bluetidepro bluetidepro force-pushed the master branch 2 times, most recently from 6cd9947 to d74e43b Compare November 29, 2016 21:16
@bluetidepro bluetidepro changed the title Fix flexbox style bug in down_panel Fix flexbox style bugs Nov 29, 2016
Copy link
Contributor

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style changes are looks great for me.
Could you rebase this branch against the master again and go with my comments?

@@ -1,5 +1,11 @@
## Change Log

### v3.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not edit this file.
That's something we do.

@@ -1,6 +1,6 @@
{
"name": "@kadira/storybook-ui",
"version": "3.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do no change this too.

@bluetidepro
Copy link
Contributor Author

@arunoda No problem at all. I updated the PR. Sorry about making the changelog/package changes. I didn't know if that was something you did or you wanted contributors to do in their PR's so I did it just in case, to be safe! :)

Good to know for the future. I'd also def recommend adding that to the https://github.com/storybooks/storybook-ui/blob/master/CONTRIBUTING.md file so others possibly know, too! 😸

Thanks Arunoda!

@arunoda arunoda merged commit b502111 into storybook-eol:master Nov 30, 2016
ndelangen pushed a commit that referenced this pull request Apr 2, 2017
docs: EggHead should be Egghead
ndelangen pushed a commit that referenced this pull request Apr 10, 2017
Use 7007 as the default port
ndelangen added a commit that referenced this pull request Apr 10, 2017
Update links to point to new organization
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants