Completely avoid re-rendering the preview iframe #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When manager re-rendered there is a chance that this component is rerendered. That makes the iframe to load again. So the complete story is remounted. This is not preferred except when changing stories.
roonyh
force-pushed
the
avoid-re-rendering-preview
branch
from
d57d124 to
039db5c
Compare
|
Superb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manager re-rendered there is a chance that this component is rerendered. That makes the iframe to load again. So the complete story is re-mounted.
This is not preferred except when changing stories.
The case of changing stories is anyway handled by communicating through the channel. So we don't need to rerender the Preview component at all.