Devtool change and error handing #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we don't use source-map and all the helpers used for that. Source map is slow and cheap source maps doesn't work well in Chrome. We also remove error enhancements which is also based on source-maps. Additionally, we now simplified the client side error handling and always throw the actual error so we can check it from the console.
This was referenced Oct 27, 2016
Closed
|
@arunoda do you know when this might make it into NPM? |
|
Today. In few hours. |
|
Amazing, thanks so much for sorting this so quickly! |
|
Would it be possible to allow this to be configurable with a build switch for the storybook, so that users don't have to change the |
|
@nottoseethesun I believe you can override this in full control mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we are changing the webpack devtool to eval in the development and we no longer use source map.
Source map with babel is always problematic and CRA don't use it.
Also, it takes time longer than other eval.
We also can't use cheap sourcemap devtools because of Chrome has some bugs on it.
We also cleanup some source map based error enhancements we did and how we handle errors.