Support read-only db with build-storybook #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,8 @@ program | |||
| .option('-s, --static-dir <dir-names>', 'Directory where to load static files from', parseList) | |||
| .option('-o, --output-dir [dir-name]', 'Directory where to store built files') | |||
| .option('-c, --config-dir [dir-name]', 'Directory where to load Storybook configurations from') | |||
| .option('-d, --db-path [db-file]', 'File where to store addon database JSON file') | |||
There was a problem hiding this comment.
May be description need to be changed to "where load from" or something similar.
There was a problem hiding this comment.
Yeah, updated it. Now it simply says path to db file.
|
I think this looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@kadira/storybook-database-localpackage now supports static JSON files as read-only DBs. This is useful when creating static storybooks with thebuild-storybookscript and hosting them on Github pages. This PR updates the static build script to copy the database file when building static storybooks.