Implement Mantra Architecture #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version lacks, back button support.
So, end user doesn't need to download the stuff we use inside the manager.
when developing the manager.
We need to support unique id for the action id since now it's possible to reload the preview iframe. So, if we use a number from 0, there's a chance for duplicate ids.
timkindberg
pushed a commit
to timkindberg/react-storybook
that referenced
this pull request
May 10, 2016
* Add preview container in preview module. * Update comments. * Implement preview module. * Add component tests. * Add tests for actions. * Add container tests. * Write tests for reducers. * Fix lint issues. * Add tests for init_pagebus * Add base ui model with the layout. * Fix the reducer. * Add select story pageBus event. * Update some test cases/ * Implement basic communication with the preview iframe. * Move actions to a common place. * Clean mantra reducers. * Integrated initial leftPanel. * Implement story filter * Add initial ActionLogger. * Add actions grouping. * Fix lint issues. * Implement initial routing. This version lacks, back button support. * Handle back button properly with routing. * Add keyboard shortcut support. * Add responsive tags. * Move all the admin dependencies to the dev env. So, end user doesn't need to download the stuff we use inside the manager. * Optimize dev build with enabling webpack when developing the manager. * Update CONTRIBUTING.md to support the new build environment. * Add proper support for production build. * Introduce the api module. * Add initial docs. * Add keyboard shortcut help dialog. * Fix lint issues. * Fix some missing tests. * Add tests for actions. * Write tests for action logger. * Add tests for layout * Add tests for left_panel.header. * Add tests for left_panel.text_filter * Add tests for left_panel.stories * Complete tests for the left panel component. * Simplyfy the container code by implementing the reduxComposer. * Add container tests. * Add ui reducer tests. * Add tests for handle key events * Add tests to handle_routing. * Add filters tests * Add tests for reduxComposer * Add tests for reduxComposer * Use a unique Id for the action.id. We need to support unique id for the action id since now it's possible to reload the preview iframe. So, if we use a number from 0, there's a chance for duplicate ids. * Update docs. * Update docs. * Add manager.js * Move redux and keycode to dependencies.
This was referenced Feb 1, 2020
This was referenced Sep 15, 2021
|
View your CI Pipeline Execution ↗ for commit 74d181e.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to a modular React Storybook version. This is almost a complete re-write with some new features.
New features includes:
Removed features: