Test UI components #103
Merged
Test UI components #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,7 +182,7 @@ export default class StorybookControls extends React.Component { | |||
| onClear={this.clearFilterText.bind(this)} | |||
| /> | |||
| </div> | |||
| <div style={listStyle}> | |||
| <div style={listStyle} className="stories-list"> | |||
There was a problem hiding this comment.
Do not use classNames just for the sake of testing.
May be we can simply get the html .html() with enzyme and do some regexp search for what you want to search.
There was a problem hiding this comment.
If there is no other option, use this.
thani-sh
force-pushed
the
test-ui-components
branch
from
ec7b726 to
7079cd0
Compare
|
Removed classes |
|
Great. |
wyattdanger
pushed a commit
to wyattdanger/react-storybook
that referenced
this pull request
Apr 26, 2016
|
View your CI Pipeline Execution ↗ for commit 7079cd0.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.